Some fixes and design tweaks:

* Fixed the game_viplist module to work with the latest vip protocols.
* Fixed a referencing error in the game_cooldown module
* Started editing the design of the popupmenu (needs more work).

modules/client_skins/skins/default/styles/buttons.otui

@@ -3,7 +3,7 @@ Button < UIButton
   color: #f0ad4dff
   size: 106 22
   text-offset: 0 0
-  image-source: /images/button.png
+  image-source: /images/button_rounded.png
   image-color: white
   image-clip: 0 0 20 20
   image-border: 2

modules/client_skins/skins/default/styles/popupmenus.otui

@@ -1,15 +1,25 @@
 PopupMenuButton < UIButton
   height: 18
-  margin-left: 3
+  margin-left: 5
-  margin-right: 3
+  margin-right: 5
+  margin-top: 1
+  margin-bottom: 1
+  size: 0 21
+  text-offset: 0 0
   font: verdana-11px-antialised
   
+  image-source: /images/button_square.png
+  image-color: white
+  image-clip: 0 0 20 20
+  image-border: 2
+
   color: #aaaaaa
   background-color: alpha
 
   $hover !disabled:
     color: #ffffff
     background-color: #ffffff44
+    image-clip: 0 40 20 20
 
   $disabled:
     color: #555555
@@ -17,6 +27,7 @@ PopupMenuButton < UIButton
 PopupMenuSeparator < UIWidget
   margin-left: 2
   margin-right: 2
+  margin-bottom: 1
   image-source: /images/menubox.png
   image-border-left: 1
   image-border-right: 1

modules/client_terminal/commands.lua

@@ -35,13 +35,11 @@ function debugContainersItems()
     if hovered then
       local item = self:getItem()
       if item then
-        local text = [[
+        local text = "id: " ..item:getId() .. 
-          id:]] ..item:getId() .. [[,
+                     "\n stackable: " ..tostring(item:isStackable()) ..
-          stackable:]] ..tostring(item:isStackable()) .. [[,
+                     "\n marketable: " ..tostring(item:isMarketable()) ..
-          marketable:]] ..tostring(item:isMarketable()) .. [[,
+                     "\n vocation: "..(item:getMarketData() and item:getMarketData().restrictVocation or 'none') ..
-          vocation:]]..(item:getMarketData() and item:getMarketData().restrictVocation or 'none') ..[[,
+                     "\n cloth slot: " ..item:getClothSlot()
-          cloth slot:]] ..item:getClothSlot() .. [[
-        ]]
         g_tooltip.display(text)
       end
     else

modules/corelib/ui/uipopupmenu.lua

@@ -41,7 +41,7 @@ function UIPopupMenu:addOption(optionName, optionCallback)
     self:getParent():destroy()
   end
   optionWidget:setText(optionName)
-  local width = optionWidget:getTextSize().width + optionWidget:getMarginLeft() + optionWidget:getMarginRight() + 6
+  local width = optionWidget:getTextSize().width + optionWidget:getMarginLeft() + optionWidget:getMarginRight() + 15
   self:setWidth(math.max(self:getWidth(), width))
 end
 

modules/game_cooldown/cooldown.lua

@@ -91,9 +91,9 @@ function onSpellCooldown(iconId, duration)
     icon:setId(spellName)
     icon:setImageSource('/game_cooldown/icons/' .. SpelllistSettings[modules.game_spelllist.getSpelllistProfile()].iconFile)
     icon:setImageClip(modules.game_spelllist.getIconImageClip(otcIconId))
-    icon.event = scheduleEvent(function() icon:destroy() end, duration)
+    icon.event = scheduleEvent(function() icon:destroy() icon = nil end, duration)
   
-    local progressRect = g_ui.createWidget('SpellProgressRect', icon)
+    local progressRect = g_ui.createWidget('SpellProgressRect')
     updateProgressRect(progressRect, duration/25, true)
     progressRect:setTooltip(spellName)
   end

modules/game_modaldialog/modaldialog.otui

@@ -1,5 +1,3 @@
-TextScrollbar < VerticalScrollBar
-
 ChoiceListLabel < Label
   font: verdana-11px-monochrome
   background-color: alpha

modules/game_viplist/viplist.lua

@@ -71,7 +71,7 @@ function addVip()
   destroyAddWindow()
 end
 
-function onAddVip(id, name, online)
+function onAddVip(id, name, state)
   local vipList = vipWindow:getChildById('contentsPanel')
 
   local label = g_ui.createWidget('VipListLabel')
@@ -79,13 +79,15 @@ function onAddVip(id, name, online)
   label:setId('vip' .. id)
   label:setText(name)
 
-  if online then
+  if state == VipState.Online then
     label:setColor('#00ff00')
+  elseif state == VipState.Pending then
+    label:setColor('#ffca38')
   else
     label:setColor('#ff0000')
   end
 
-  label.vipOnline = online
+  label.vipState = state
 
   label:setPhantom(false)
   connect(label, { onDoubleClick = function () g_game.openPrivateChannel(label:getText()) return true end } )
@@ -95,12 +97,13 @@ function onAddVip(id, name, online)
 
   for i=1,childrenCount do
     local child = vipList:getChildByIndex(i)
-    if online and not child.vipOnline then
+    if state == VipState.Online and not child.vipState == VipState.Online then
       vipList:insertChild(i, label)
       return
     end
 
-    if (not online and not child.vipOnline) or (online and child.vipOnline) then
+    if (not state == VipState.Online and not child.vipState == VipState.Online)
+      or (state == VipState.Online and child.vipState == VipState.Online) then
       local childText = child:getText():lower()
       local length = math.min(childText:len(), nameLower:len())
 
@@ -118,13 +121,13 @@ function onAddVip(id, name, online)
   vipList:insertChild(childrenCount+1, label)
 end
 
-function onVipStateChange(id, online)
+function onVipStateChange(id, state)
   local vipList = vipWindow:getChildById('contentsPanel')
   local label = vipList:getChildById('vip' .. id)
   local text = label:getText()
   label:destroy()
 
-  onAddVip(id, text, online)
+  onAddVip(id, text, state)
 end
 
 function onVipListMousePress(widget, mousePos, mouseButton)

modules/gamelib/const.lua

@@ -174,4 +174,10 @@ PathFindFlags = {
   AllowNonWalkable = 8
 }
 
+VipState = {
+  Offline = 0,
+  Online = 1,
+  Pending = 2
+}
+
 -- @}