fix issue in move window, allow 861 protocols, update todo, remove wrong code from spinbox

TODO

@@ -22,9 +22,6 @@ fix use with
 move windows
 let windows open while playing
 fix auto repeats in lineedit
-trade
-battlelist
-offer window
 
 ====================================================
 Low priority TODO
@@ -43,6 +40,8 @@ use hardware buffer
 use indices
 fix opacity and cached framebuffers conflict
 
+map rendering could be optimized to infinite zoom out using quadtree voxels
+
 == Lua
 make possible to bind non LuaObject derived classes on lua engine (for usage with Point,Rect,Color,Size)
 review usage of x,y/width,height in lua instead of point/size
@@ -76,6 +75,7 @@ terminal/console scrolling
 auto walk
 hotkeys window
 trade window
+shop window
 battle list
 implement left panel with dragging windows
 clean sprites cache periodically

modules/core_widgets/uispinbox.lua

@@ -52,14 +52,6 @@ function UISpinBox:onMouseWheel(mousePos, direction)
   return true
 end
 
-function UISpinBox:onStyleApply(styleName, styleNode)
-  if styleNode.options then
-    for k,option in pairs(styleNode.options) do
-      self:addOption(option)
-    end
-  end
-end
-
 function UISpinBox:onTextChange(text)
   local number = tonumber(text)
   if not number or number > self.m_maximum or number < self.m_minimum then

modules/game/movewindow.otui

@@ -1,21 +1,21 @@
 MainWindow
   text: Move Item
   size: 196 112
-  @onEscape: self:getParent():destroy()
-  
+  @onEscape: self:destroy()
+
   Label
     text: Amount:
     width: 64
     anchors.left: parent.left
     anchors.top: parent.top
     margin-top: 2
-    
+
   SpinBox
     id: spinbox
     anchors.left: prev.right
     anchors.right: parent.right
     anchors.top: parent.top
-    
+
   HorizontalSeparator
     id: separator
     anchors.left: parent.left

src/otclient/net/protocolcodes.h

@@ -25,7 +25,7 @@
 
 #include <otclient/global.h>
 
-#if PROTOCOL != 860 && PROTOCOL != 862
+#if PROTOCOL < 860 || PROTOCOL > 862
 #error "the supplied protocol version is not supported"
 #endif
 
@@ -49,7 +49,7 @@ namespace Proto {
 
 #if PROTOCOL==860
     const int NumViolationReasons = 20;
-#elif PROTOCOL==862
+#elif PROTOCOL==861 || PROTOCOL==862
     const int NumViolationReasons = 19;
 #endif
 
@@ -221,7 +221,7 @@ namespace Proto {
     };
 
     enum SpeakTypes {
-#if PROTOCOL==862
+#if PROTOCOL==861 || PROTOCOL==862
         SpeakSay = 1,
         SpeakWhisper,
         SpeakYell,
@@ -265,18 +265,7 @@ namespace Proto {
     };
 
     enum MessageTypes {
-#if PROTOCOL==860
-        MessageConsoleRed = 18,
-        MessageConsoleOrange,
-        MessageConsoleOrange2,
-        MessageWarning,
-        MessageEventAdvance,
-        MessageEventDefault,
-        MessageStatusDefault,
-        MessageInfoDescription ,
-        MessageStatusSmall,
-        MessageConsoleBlue
-#elif PROTOCOL==862
+#if PROTOCOL==862 || PROTOCOL==861
         MessageConsoleOrange = 13,
         MessageConsoleOrange2,
         MessageWarning,
@@ -287,6 +276,17 @@ namespace Proto {
         MessageStatusSmall,
         MessageConsoleBlue,
         MessageConsoleRed
+#elif PROTOCOL==860
+        MessageConsoleRed = 18,
+        MessageConsoleOrange,
+        MessageConsoleOrange2,
+        MessageWarning,
+        MessageEventAdvance,
+        MessageEventDefault,
+        MessageStatusDefault,
+        MessageInfoDescription ,
+        MessageStatusSmall,
+        MessageConsoleBlue
 #endif
     };